feat: add `daemon` command and gRPC `list` support #46

MatteoPologruto · 2025-12-10T08:06:39Z

Motivation

Add gRPC daemon support for the list function.

Change description

Add gRPC daemon support for the list function.

Additional Notes

It can be tested following these steps:

Open a terminal.
Start the Arduino Flasher CLI gRPC daemon:

$ arduino-flasher-cli daemon

Daemon is now listening on 127.0.0.1:50052
{"IP":"127.0.0.1","Port":"50052"}

Open another terminal.
Run the following grpcurl command in the new terminal to create a gRPC client instance:

$ grpcurl \
  -plaintext \
  -import-path ./rpc \
  -proto cc/arduino/flasher/v1/commands.proto \
  127.0.0.1:50052 \
  cc.arduino.flasher.v1.Flasher.List

Reviewer checklist

PR addresses a single concern.
PR title and description are properly filled.
Changes will be merged in main.
Changes are covered by tests.
Logging is meaningful in case of troubleshooting.

cmd/arduino-flasher-cli/daemon/daemon.go

cmaglie · 2025-12-10T11:17:21Z

service/service_list.go

+		latest := false
+		if manifest.Releases[i].Version == manifest.Latest.Version {
+			latest = true
+		}


Suggested change

latest := false

if manifest.Releases[i].Version == manifest.Latest.Version {

latest = true

}

latest := (manifest.Releases[i].Version == manifest.Latest.Version)

Also, it's unclear why you're looping in reverse here.

The json manifest we get contains the latest release in the last element of the array, but we decided that we want to return it as the first item of Releases

We should not depend on how the input data is sorted; it happens to be that way, but it is not guaranteed.

rpc/cc/arduino/flasher/cli/commands/v1/commands.proto

Co-authored-by: Cristian Maglie <c.maglie@bug.st>

lucarin91 · 2025-12-10T13:56:19Z

Taskfile.yml

+  protoc:compile:
+    desc: Compile protobuf definitions
+    cmds:
+      - buf dep update


I would install buf as a go tool. You can run go get --tool github.com/bufbuild/buf to add the latest buf version in the go.mod, and then here you can write

Suggested change

- buf dep update

- go tool buf dep update

lucarin91 · 2025-12-10T13:59:51Z

cmd/arduino-flasher-cli/daemon/daemon.go

+
+	daemonCommand.Flags().StringVar(&daemonPort,
+		"port", "50052",
+		i18n.Tr("The TCP port the daemon will listen to"))


Suggested change

i18n.Tr("The TCP port the daemon will listen to"))

i18n.Tr("The TCP port the daemon will listen to, 0 for random port"))

lucarin91 · 2025-12-10T15:52:45Z

cmd/arduino-flasher-cli/daemon/daemon.go

+	"github.com/arduino/arduino-flasher-cli/cmd/feedback"
+	"github.com/arduino/arduino-flasher-cli/cmd/i18n"
+
+	flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1"


Suggested change

"github.com/arduino/arduino-flasher-cli/cmd/feedback"

"github.com/arduino/arduino-flasher-cli/cmd/i18n"

flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1"

"github.com/arduino/arduino-flasher-cli/cmd/feedback"

"github.com/arduino/arduino-flasher-cli/cmd/i18n"

flasher "github.com/arduino/arduino-flasher-cli/rpc/cc/arduino/flasher/v1"

lucarin91 · 2025-12-10T15:54:47Z

cmd/arduino-flasher-cli/daemon/daemon.go

+	}
+
+	daemonCommand.Flags().StringVar(&daemonPort,
+		"port", "50052",


I would use a random port by default

Suggested change

"port", "50052",

"port", "0",

lucarin91 · 2025-12-10T16:03:46Z

service/service_list.go

+		latest := false
+		if manifest.Releases[i].Version == manifest.Latest.Version {
+			latest = true
+		}
+		resp.Releases = append(resp.Releases, &flasher.Release{BuildId: manifest.Releases[i].Version, Latest: latest})


Cannot this be simplified in the following?

Suggested change

latest := false

if manifest.Releases[i].Version == manifest.Latest.Version {

latest = true

}

resp.Releases = append(resp.Releases, &flasher.Release{BuildId: manifest.Releases[i].Version, Latest: latest})

resp.Releases = append(resp.Releases, &flasher.Release{

BuildId: manifest.Releases[i].Version,

Latest: manifest.Releases[i].Version == manifest.Latest.Version

})

lucarin91 · 2025-12-10T16:06:17Z

cmd/arduino-flasher-cli/main.go

 		list.NewListCmd(),
 		download.NewDownloadCmd(),
 		version.NewVersionCmd(Version),
+		daemon.NewDaemonCommand(srv),


Suggested change

daemon.NewDaemonCommand(srv),

daemon.NewDaemonCommand(service.NewFlasherServer()),

lucarin91 · 2025-12-10T16:06:25Z

cmd/arduino-flasher-cli/main.go

+	srv := service.NewFlasherServer()
+


Suggested change

srv := service.NewFlasherServer()

lucarin91 · 2025-12-10T16:08:19Z

cmd/arduino-flasher-cli/daemon/daemon.go

+
+func (r daemonResult) String() string {
+	j, _ := json.Marshal(r)
+	return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) + fmt.Sprintln(string(j))


Why are you including the JSON?

Suggested change

return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) + fmt.Sprintln(string(j))

return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port))

MatteoPologruto self-assigned this Dec 10, 2025

MatteoPologruto added the enhancement New feature or request label Dec 10, 2025

MatteoPologruto force-pushed the daemon-grpc branch from dc206b4 to ba718f5 Compare December 10, 2025 08:10

MatteoPologruto linked an issue Dec 10, 2025 that may be closed by this pull request

[App Lab integration] List the available images #42

Open

MatteoPologruto marked this pull request as ready for review December 10, 2025 08:30

MatteoPologruto requested review from a team and cmaglie December 10, 2025 08:30

cmaglie requested changes Dec 10, 2025

View reviewed changes

Base automatically changed from flash-command-refactoring to main December 10, 2025 15:15

MatteoPologruto and others added 6 commits December 10, 2025 16:21

Add daemon command and gRPC list support

a295189

Print releases in reverse order

0014075

Add buf.yaml file

3c5a404

Update cmd/arduino-flasher-cli/daemon/daemon.go

8e2e127

Co-authored-by: Cristian Maglie <c.maglie@bug.st>

Rename ArduinoCoreService to FlasherService

60f327a

Some more renaming

d3b72e1

MatteoPologruto force-pushed the daemon-grpc branch from 974c302 to d3b72e1 Compare December 10, 2025 15:22

Run task fmt

ac721be

lucarin91 requested changes Dec 10, 2025

View reviewed changes

	i18n.Tr("The TCP port the daemon will listen to"))
	i18n.Tr("The TCP port the daemon will listen to, 0 for random port"))

	daemon.NewDaemonCommand(srv),
	daemon.NewDaemonCommand(service.NewFlasherServer()),

	return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port)) + fmt.Sprintln(string(j))
	return fmt.Sprintln(i18n.Tr("Daemon is now listening on %s:%s", r.IP, r.Port))

feat: add daemon command and gRPC list support #46

Are you sure you want to change the base?

feat: add daemon command and gRPC list support #46

Uh oh!

Conversation

MatteoPologruto commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Change description

Additional Notes

Reviewer checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `daemon` command and gRPC `list` support #46

feat: add `daemon` command and gRPC `list` support #46

MatteoPologruto commented Dec 10, 2025 •

edited

Loading